fix: add silence leave for premiumvanish#168
Open
ChipWolf wants to merge 1 commit intoMultiChat:masterfrom
Open
fix: add silence leave for premiumvanish#168ChipWolf wants to merge 1 commit intoMultiChat:masterfrom
ChipWolf wants to merge 1 commit intoMultiChat:masterfrom
Conversation
akshualy
reviewed
Feb 26, 2021
Contributor
akshualy
left a comment
akshualy
left a comment
There was a problem hiding this comment.
Change comment & should be fine.
Author
|
@OllieMartin ready for you to merge |
Author
|
@Gadsee do you have merge access? |
ChipWolf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What, briefly, is the purpose of this pull request?
Adds functionality to silence leave messages if the user is vanished with PremiumVanish.
Is this pull request related to an issue with the plugin?
Fixes #167
What is the status of this pull request? [e.g. In Development, Undergoing Final Testing, Ready]
Ready for merge
Changes
What currently existing parts of the plugin are affected by this pull request
If users vanish with PremiumVanish, it sends a fake leave message. If they then leave the server, there's another leave message. Users which are vanished with PremiumVanish cannot leave incognito.
What new features are added to the plugin by this pull request
An option to silence leave messages if a user is vanished with PremiumVanish.
Standards
Does this pull request adhere to basic Java coding standards?
I matched the standard of the existing code implemented to silence the join messages.
Does this pull request seem to stay true to the style used so far in the MultiChat code.
Yes, it's essentially a copy and paste job :)